[webkit-reviews] review denied: [Bug 188696] beforeunload interoperability issues : [Attachment 350504] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied PhistucK <phistuck at chromium.org>'s
request for review:
Bug 188696: beforeunload interoperability issues
https://bugs.webkit.org/show_bug.cgi?id=188696

Attachment 350504: Patch

https://bugs.webkit.org/attachment.cgi?id=350504&action=review




--- Comment #31 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 350504
  --> https://bugs.webkit.org/attachment.cgi?id=350504
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350504&action=review

> Source/WebCore/ChangeLog:7
> +

The change log should state why we're making this change, reference relevant
spec text, and explain how we're implementing that.
r- due to the lack of the change log description.

> LayoutTests/ChangeLog:9
> +	   Had to remove the event listeners once the test is done, otherwise
> +	   they would show a beforeunload alert on the next test for some
reason.

We should investigate why that's happening and fix WebCore / WebKitTestRunner /
DumpRenderTree instead of updating tests.
r- because of this.