[webkit-reviews] review granted: [Bug 189777] Use a Variant for FormDataElement : [Attachment 350335] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 189777: Use a Variant for FormDataElement
https://bugs.webkit.org/show_bug.cgi?id=189777

Attachment 350335: Patch

https://bugs.webkit.org/attachment.cgi?id=350335&action=review




--- Comment #25 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 350335
  --> https://bugs.webkit.org/attachment.cgi?id=350335
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350335&action=review

r=me

> Source/WebCore/platform/network/FormData.cpp:142
> +    return WTF::visit(WTF::makeVisitor(

SwitchOn() ?

> Source/WebCore/platform/network/FormData.cpp:160
> +    return WTF::visit(WTF::makeVisitor(

SwitchOn() ?

> Source/WebCore/platform/network/FormData.cpp:358
> +	   WTF::visit(WTF::makeVisitor(

SwitchOn() ?

> Source/WebCore/platform/network/FormData.h:44
> +    FormDataElement(Data&& data)

Why isn't this explicit ?

> Source/WebCore/platform/network/FormData.h:75
> +	   bool shouldGenerateFile { false };

Can we pack this better and move all booleans to the end?

> Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp:139
> +    bool success = WTF::visit(WTF::makeVisitor(

SwitchOn() ?

> Source/WebCore/platform/network/curl/CurlFormDataStream.cpp:127
> +	   std::optional<size_t> readBytes = WTF::visit(WTF::makeVisitor(

SwitchOn() ?

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:77
> +	   return WTF::visit(WTF::makeVisitor(

SwitchOn() ?

> Source/WebKit/WebProcess/WebCoreSupport/SessionStateConversion.cpp:45
> +	   WTF::visit(WTF::makeVisitor(

SwitchOn() ?