[webkit-reviews] review granted: [Bug 184307] Custom elements in a reaction queue can lose its JS wrapper and become HTMLUnknownElement : [Attachment 350178] Fixes the bug

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 184307: Custom elements in a reaction queue can lose its JS wrapper and
become HTMLUnknownElement
https://bugs.webkit.org/show_bug.cgi?id=184307

Attachment 350178: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=350178&action=review




--- Comment #22 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 350178
  --> https://bugs.webkit.org/attachment.cgi?id=350178
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=350178&action=review

r=me if you answer my question?

> Source/WebCore/dom/StrongNodeRef.cpp:35
> +    static NeverDestroyed<HashCountedSet<Node*>> map;

Are there any Nodes that can exist in a worker? If they can't, can you add an
assertion that we are on the MainThread?