[webkit-reviews] review granted: [Bug 189719] Simply authentication code even more! : [Attachment 350148] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 189719: Simply authentication code even more!
https://bugs.webkit.org/show_bug.cgi?id=189719

Attachment 350148: Patch

https://bugs.webkit.org/attachment.cgi?id=350148&action=review




--- Comment #5 from Andy Estes <aestes at apple.com> ---
Comment on attachment 350148
  --> https://bugs.webkit.org/attachment.cgi?id=350148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350148&action=review

r=me, but toAuthenticationChallengeDisposition has a bug you need to fix.

> Source/WebKit/Shared/Authentication/AuthenticationChallengeDisposition.h:49
> +    WebKit::AuthenticationChallengeDisposition,
> +    WebKit::AuthenticationChallengeDisposition::UseCredential,
> +    WebKit::AuthenticationChallengeDisposition::PerformDefaultHandling,
> +    WebKit::AuthenticationChallengeDisposition::Cancel,
> +   
WebKit::AuthenticationChallengeDisposition::RejectProtectionSpaceAndContinue

Needs more indentation.

> Source/WebKit/UIProcess/API/C/WKPage.cpp:2153
> -		   return
authenticationChallenge.listener().rejectProtectionSpaceAndContinue();
> +	       return
authenticationChallenge.listener().completeChallenge(WebKit::AuthenticationChal
lengeDisposition::RejectProtectionSpaceAndContinue);

Ditto.

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:861
> +    case NSURLSessionAuthChallengeCancelAuthenticationChallenge:
> +	   return AuthenticationChallengeDisposition::UseCredential;

Shouldn't this map to AuthenticationChallengeDisposition::Cancel?