[webkit-reviews] review granted: [Bug 189808] Web Inspector: remove Legacy Style Editor : [Attachment 350333] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 189808: Web Inspector: remove Legacy Style Editor
https://bugs.webkit.org/show_bug.cgi?id=189808

Attachment 350333: Patch

https://bugs.webkit.org/attachment.cgi?id=350333&action=review




--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 350333
  --> https://bugs.webkit.org/attachment.cgi?id=350333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350333&action=review

r=me. Awesome, this looks like a pretty thorough removal!

> Source/WebInspectorUI/ChangeLog:16
> +	   * Tools/PrettyPrinting/index.html:

Nice!

> Source/WebInspectorUI/ChangeLog:104
> +	   * UserInterface/Views/CodeMirrorFormatters.js:
> +	   Remove "css-rule" CodeMirror mode.

The CodeMirror "javascript" formatter in here can actually be removed as well.
I always thought we might use it for smaller chunks of things but it looks like
it is unreachable now. We can remove that in a separate patch.

> LayoutTests/inspector/css/css-property.html:190
> -			   InspectorTest.expectEqual(property.text,
"background-repeat-y: repeat;", `"${property.name}" has the text
"background-repeat-y: repeat;".`);
> +			   InspectorTest.expectEqual(property.text, "",
`"${property.name}" has the text "".`);

This seems different.