[webkit-reviews] review granted: [Bug 189778] [JSC] Enable LLInt ASM interpreter on X64 and ARM64 in non JIT configuration : [Attachment 350355] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 189778: [JSC] Enable LLInt ASM interpreter on X64 and ARM64 in non JIT
configuration
https://bugs.webkit.org/show_bug.cgi?id=189778

Attachment 350355: Patch

https://bugs.webkit.org/attachment.cgi?id=350355&action=review




--- Comment #11 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 350355
  --> https://bugs.webkit.org/attachment.cgi?id=350355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350355&action=review

r=me with some nits.

> Source/JavaScriptCore/ChangeLog:10
> +	   configuration in X86_64 and ARM64.

Nit: configurations

> Source/JavaScriptCore/ChangeLog:12
> +	   This patch enables LLInt for non JIT in X86_64 and ARM64
architectures.

Nit: maybe "for non JIT in" => "for non JIT builds on"

> Source/JavaScriptCore/ChangeLog:14
> +	   configuration. But it is wrong in the new scenario since we have a
buildx

typo: "buildx" => "build"?

> Source/JavaScriptCore/jit/HostCallReturnValue.cpp:-38
> -// Nothing to see here.

Lol solid comment.