[webkit-reviews] review granted: [Bug 189801] WebSQL: User cannot grant quota increase if the JS provides an expected usage value that is too low : [Attachment 350275] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 189801: WebSQL: User cannot grant quota increase if the JS provides an
expected usage value that is too low
https://bugs.webkit.org/show_bug.cgi?id=189801

Attachment 350275: Patch

https://bugs.webkit.org/attachment.cgi?id=350275&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 350275
  --> https://bugs.webkit.org/attachment.cgi?id=350275
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350275&action=review

> Source/WebCore/Modules/webdatabase/Database.cpp:797
> +    if (estimatedSize() <= oldQuota) {

Is the name oldQuota misleading?
It seems like oldQuota is the current database size while estimatedSize is the
'quota' defined by the page.

> Source/WebCore/Modules/webdatabase/Database.cpp:800
> +	   setEstimatedSize(oldQuota + 5 * 1024. * 1024.);

Should we move this as a macro with a name like QUOTA_SIZE_INCREMENT?

> Source/WebCore/Modules/webdatabase/Database.h:92
> +    void setEstimatedSize(unsigned);

Can we make setEstimatedSize private?
And maybe estimatedSize as well.