[webkit-reviews] review denied: [Bug 187302] [libwebrtc] Allow IP mismatch for local connections on localhost : [Attachment 350350] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has denied Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 187302: [libwebrtc] Allow IP mismatch for local connections on localhost
https://bugs.webkit.org/show_bug.cgi?id=187302

Attachment 350350: Patch

https://bugs.webkit.org/attachment.cgi?id=350350&action=review




--- Comment #12 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 350350
  --> https://bugs.webkit.org/attachment.cgi?id=350350
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350350&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/tcpport.cc:-354
> -    RTC_DCHECK(std::find_if(desired_addresses.begin(),
desired_addresses.end(),

I think we can use the webkit compilation define WEBRTC_WEBKIT_BUILD, that way
we can try to avoid the patch is removed again in the next merge. At least
until we can merge upstream.