[webkit-reviews] review granted: [Bug 189823] TransformationMatrix::toColumnMajorFloatArray() should return a std::array<> object : [Attachment 350348] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 21 04:27:01 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 189823: TransformationMatrix::toColumnMajorFloatArray() should return a
std::array<> object
https://bugs.webkit.org/show_bug.cgi?id=189823

Attachment 350348: Patch

https://bugs.webkit.org/attachment.cgi?id=350348&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 350348
  --> https://bugs.webkit.org/attachment.cgi?id=350348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350348&action=review

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1727
> -void TransformationMatrix::toColumnMajorFloatArray(FloatMatrix4& result)
const
> +auto TransformationMatrix::toColumnMajorFloatArray() const -> FloatMatrix4

Wow, a good use of the trailing return syntax...


More information about the webkit-reviews mailing list