[webkit-reviews] review granted: [Bug 156674] Build tools should work when the /usr/bin/python is python3 : [Attachment 350303] Updated patch.

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Mike Gorse
<mgorse at suse.com>'s request for review:
Bug 156674: Build tools should work when the /usr/bin/python is python3
https://bugs.webkit.org/show_bug.cgi?id=156674

Attachment 350303: Updated patch.

https://bugs.webkit.org/attachment.cgi?id=350303&action=review




--- Comment #28 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 350303
  --> https://bugs.webkit.org/attachment.cgi?id=350303
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=350303&action=review

OK, thanks!

The try/except imports are a bit yucky, but I guess that's what we're stuck
with if we have XCode doing something different than CMake.

> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_model.py:159
> +    def __lt__(self, other):
> +	   return self.function_name < other.function_name

Why is it needed?

> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_model.py:309
> +	   return list(map(BuiltinFunction.fromString, functionStrings))

You've done this in a couple other places. Why do you need to wrap the map in a
list?