[webkit-reviews] review requested: [Bug 189606] Web Inspector: group media network entries by the node that triggered the request : [Attachment 350230] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 20 10:44:13 PDT 2018
Devin Rousso <drousso at apple.com> has asked for review:
Bug 189606: Web Inspector: group media network entries by the node that
triggered the request
https://bugs.webkit.org/show_bug.cgi?id=189606
Attachment 350230: Patch
https://bugs.webkit.org/attachment.cgi?id=350230&action=review
--- Comment #32 from Devin Rousso <drousso at apple.com> ---
Created attachment 350230
--> https://bugs.webkit.org/attachment.cgi?id=350230&action=review
Patch
The canvas test failures were caused by `InspectorCanvas::buildObjectForCanvas`
eagerly binding the canvas' node in `InspectorDOMAgent`, which will not be
removed if the canvas' node is detached from the DOM since we unbind nodes in
`InspectorDOMAgent` when they are removed from their parent.
More information about the webkit-reviews
mailing list