[webkit-reviews] review granted: [Bug 189729] JS bindings generator should support EnabledAtRuntime for static methods : [Attachment 350161] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 20 09:18:44 PDT 2018


Chris Dumez <cdumez at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 189729: JS bindings generator should support EnabledAtRuntime for static
methods
https://bugs.webkit.org/show_bug.cgi?id=189729

Attachment 350161: Patch

https://bugs.webkit.org/attachment.cgi?id=350161&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 350161
  --> https://bugs.webkit.org/attachment.cgi?id=350161
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350161&action=review

r=me

> Source/WebCore/ChangeLog:6
> +	   Add support for EnabledAtRuntime to static methods in the JS
bindings

The description should come after...

> Source/WebCore/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).

... the reviewed by line.


More information about the webkit-reviews mailing list