[webkit-reviews] review granted: [Bug 189782] [MSE] Use some tolerance when deciding whether a frame should be appended to the decode queue : [Attachment 350185] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 189782: [MSE] Use some tolerance when deciding whether a frame should be
appended to the decode queue
https://bugs.webkit.org/show_bug.cgi?id=189782

Attachment 350185: Patch

https://bugs.webkit.org/attachment.cgi?id=350185&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 350185
  --> https://bugs.webkit.org/attachment.cgi?id=350185
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350185&action=review

> Source/WebCore/ChangeLog:7
> +	   should not overlap. Unfortunately, there are lots of muxes out there

muxers

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1696
> +	   // lastEnqueuedDecodeEndTime or even a bit before that to accomodate
muxes with imprecise timing information.

muxers

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1698
> +	   // There are many muxes out there where the frame times are not
perfectly contiguous, therefore a tolerance is needed.

muxers