[webkit-reviews] review granted: [Bug 189699] [GStreamer] Utilities cleanups : [Attachment 350115] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 20 01:15:26 PDT 2018


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 189699: [GStreamer] Utilities cleanups
https://bugs.webkit.org/show_bug.cgi?id=189699

Attachment 350115: Patch

https://bugs.webkit.org/attachment.cgi?id=350115&action=review




--- Comment #12 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 350115
  --> https://bugs.webkit.org/attachment.cgi?id=350115
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350115&action=review

Thanks Phil for the patch! And thanks Charlie for the informal reviews!

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:83
> +    GstMappedBuffer() = default;

Do we need this constructor? Does it make sense? I cannot think of a useful
case of this. Maybe = delete?


More information about the webkit-reviews mailing list