[webkit-reviews] review granted: [Bug 189774] Adopt safe-area-inset on ImageDocument : [Attachment 350166] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 189774: Adopt safe-area-inset on ImageDocument
https://bugs.webkit.org/show_bug.cgi?id=189774

Attachment 350166: Patch

https://bugs.webkit.org/attachment.cgi?id=350166&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 350166
  --> https://bugs.webkit.org/attachment.cgi?id=350166
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350166&action=review

> Source/WebCore/ChangeLog:8
> +	   rdar://problem/44624432

People usually put this up on the line immediately below the bugzilla link.
Unless you're being weird on purpose like Beth.

> Source/WebCore/html/ImageDocument.cpp:236
> +	   imageElement->setAttribute(styleAttr, "-webkit-user-select:none;
display:block; margin:auto; padding:env(safe-area-inset-top)
env(safe-area-inset-right) env(safe-area-inset-bottom)
env(safe-area-inset-left)");

Trailing semicolons like we had before? Doesn't really matter.

> Source/WebCore/html/ImageDocument.cpp:238
> +	   imageElement->setAttribute(styleAttr, "-webkit-user-select:none;
padding:env(safe-area-inset-top) env(safe-area-inset-right)
env(safe-area-inset-bottom) env(safe-area-inset-left)");

I wish I had added a shorthand for this :P