[webkit-reviews] review granted: [Bug 189768] Add functions to measure memory footprint to JSC : [Attachment 350159] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 189768: Add functions to measure memory footprint to JSC
https://bugs.webkit.org/show_bug.cgi?id=189768

Attachment 350159: Patch

https://bugs.webkit.org/attachment.cgi?id=350159&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 350159
  --> https://bugs.webkit.org/attachment.cgi?id=350159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350159&action=review

r=me

> Source/JavaScriptCore/jsc.cpp:1204
> +class JSCMemoryFootprint : public JSDestructibleObject {

nit: I think this could inherit from JSNonFinalObject