[webkit-reviews] review granted: [Bug 189762] [Web Animations] Provide a way to query accelerated animations for internal testing : [Attachment 350142] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 189762: [Web Animations] Provide a way to query accelerated animations for
internal testing
https://bugs.webkit.org/show_bug.cgi?id=189762

Attachment 350142: Patch

https://bugs.webkit.org/attachment.cgi?id=350142&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 350142
  --> https://bugs.webkit.org/attachment.cgi?id=350142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350142&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4245
> +	       const auto& propertyAnimations = it.value;

Is there a benefit to saying const?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:174
> +    WEBCORE_EXPORT Vector<std::pair<String, double>>
acceleratedAnimationsForTesting() const override;

This could probably be final.