[webkit-reviews] review granted: [Bug 189673] Web Inspector: move DarkMode.css rules into appropriate CSS files : [Attachment 350152] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 189673: Web Inspector: move DarkMode.css rules into appropriate CSS files
https://bugs.webkit.org/show_bug.cgi?id=189673

Attachment 350152: Patch

https://bugs.webkit.org/attachment.cgi?id=350152&action=review




--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 350152
  --> https://bugs.webkit.org/attachment.cgi?id=350152
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350152&action=review

r=me, with a few minor things.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:336
> +    but close enough for now. It needs to use partial translucency so that
the selection area shines through. */

Is there a bug that can be referenced here?

> Source/WebInspectorUI/UserInterface/Views/Main.css:136
> +    background-color: var(--background-color-content);

Can this change go in https://webkit.org/b/189766 instead?

> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.css:82
> + at media all {

So the banner style applies to both light and dark mode? Why do we need "@media
all" here?

> Source/WebInspectorUI/UserInterface/Views/TabBar.css:368
> +	   /* FIXME: Use semantic colors */

Is there a bug that can be referenced here?

> Source/WebInspectorUI/UserInterface/Views/Variables.css:144
> +    /* FIXME: Use CSS4 color functions once they're available. */

Could you file a bug for this and add a reference?

> Source/WebInspectorUI/UserInterface/Views/Variables.css:266
> +	   /* FIXME: these properties are duplicated so that they have higher
specificity than WebKit's stylesheet.

If the workaround isn't temporary, you can drop the FIXME from this explanatory
comment.