[webkit-reviews] review denied: [Bug 156674] Build tools should work when the /usr/bin/python is python3 : [Attachment 350121] Updated patch.

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Mike Gorse
<mgorse at suse.com>'s request for review:
Bug 156674: Build tools should work when the /usr/bin/python is python3
https://bugs.webkit.org/show_bug.cgi?id=156674

Attachment 350121: Updated patch.

https://bugs.webkit.org/attachment.cgi?id=350121&action=review




--- Comment #25 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 350121
  --> https://bugs.webkit.org/attachment.cgi?id=350121
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=350121&action=review

> Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:32
> +from .models import PrimitiveType, ObjectType, ArrayType, EnumType,
AliasedType, Frameworks

Mac bots say:

ValueError: Attempted relative import in non-package

It's probably easier to test locally with python2 to make sure it still works
there, rather than relying on the Mac bots to do it.