[webkit-reviews] review granted: [Bug 189663] REGRESSION (PSON): White or Black flash occurs when process swapping on navigation on Mac : [Attachment 350116] patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 189663: REGRESSION (PSON): White or Black flash occurs when process
swapping on navigation on Mac
https://bugs.webkit.org/show_bug.cgi?id=189663

Attachment 350116: patch

https://bugs.webkit.org/attachment.cgi?id=350116&action=review




--- Comment #22 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 350116
  --> https://bugs.webkit.org/attachment.cgi?id=350116
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350116&action=review

r=me with comments.

> Source/WebKit/UIProcess/WebPageProxy.cpp:2454
> +	       process().send(Messages::WebPage::SetIsSuspended(true),
pageID());

I am wondering if we still need this IPC given that the WebProcess already gets
a Policy decision IPC with PolicyAction::Suspend. Also, with your change,
SetIsSuspended(true) IPC is sent twice to the process I believe.

> Source/WebKit/mac/postprocess-framework-headers.sh:56
> +	   IOS_VERSION="12.0"

Why this change?