[webkit-reviews] review canceled: [Bug 189584] [GStreamer] WebAudio idle/silence playback improvements : [Attachment 349662] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 19 08:09:15 PDT 2018


Philippe Normand <pnormand at igalia.com> has canceled  review:
Bug 189584: [GStreamer] WebAudio idle/silence playback improvements
https://bugs.webkit.org/show_bug.cgi?id=189584

Attachment 349662: Patch

https://bugs.webkit.org/attachment.cgi?id=349662&action=review




--- Comment #5 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 349662
  --> https://bugs.webkit.org/attachment.cgi?id=349662
Patch

Well, actually :)
After checking this patch more carefully, I wonder if we can perhaps have
something different than a workaround.

I would like to experiment with a rewrite of this src element, make it inherit
from audiosrc. An audio converter would internally handle the conversion to
interleaved layout.

I started a patch...


More information about the webkit-reviews mailing list