[webkit-reviews] review granted: [Bug 189502] [WHLSL] Improve test suite type safety : [Attachment 349456] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Thomas Denney
<tdenney at apple.com>'s request for review:
Bug 189502: [WHLSL] Improve test suite type safety
https://bugs.webkit.org/show_bug.cgi?id=189502

Attachment 349456: Patch

https://bugs.webkit.org/attachment.cgi?id=349456&action=review




--- Comment #8 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 349456
  --> https://bugs.webkit.org/attachment.cgi?id=349456
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349456&action=review

> Tools/WebGPUShadingLanguageRI/Test.js:-2625
> -    checkUint(program, callFunction(program, "foo", [makeUint(program, -1),
makeUint(program, 5)]), 134217727);

Can we replace all of these tests with 2^32-1 instead?