[webkit-reviews] review granted: [Bug 189707] Implement sender/receiver getStats : [Attachment 350045] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 189707: Implement sender/receiver getStats
https://bugs.webkit.org/show_bug.cgi?id=189707

Attachment 350045: Patch

https://bugs.webkit.org/attachment.cgi?id=350045&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 350045
  --> https://bugs.webkit.org/attachment.cgi?id=350045
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350045&action=review

>
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
:272
> +    auto transceiver = RTCRtpTransceiver::create(RTCRtpSender::create(*this,
"video", { }, WTFMove(senderBackend)), receiver.copyRef(), nullptr);

Nit: "video"_s

>
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
:295
> +    auto transceiver = RTCRtpTransceiver::create(RTCRtpSender::create(*this,
"audio", { }, WTFMove(senderBackend)), receiver.copyRef(), nullptr);

Nit: "audio"_s