[webkit-reviews] review requested: [Bug 188891] REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent : [Attachment 347934] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has asked  for review:
Bug 188891: REGRESSION (r232991): Switching to dark mode in Mail does not
update the message view to be transparent
https://bugs.webkit.org/show_bug.cgi?id=188891

Attachment 347934: Patch

https://bugs.webkit.org/attachment.cgi?id=347934&action=review




--- Comment #4 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 347934
  --> https://bugs.webkit.org/attachment.cgi?id=347934
Patch

Yesterday and this morning I tried to write an API test for this. I was not
able to recreate the bug in the test harness -- only in Mail. 

In the test runner, rootBackgroundColorOrTransparencyChanged() ends upon
getting called with extendedBackgroundColorChanged as true and then false in
short succession. So the bad early return was blocking
updateRootLayerConfiguration() first, but then ends up getting it scheduled
soon after then the color does not change.

Maybe you have a suggestion on how to write a test for this, but I'm at a loss.

Can we just get this landed? Reverting the bad part of r232991 and returning us
to the old behavior of no early return.