[webkit-reviews] review granted: [Bug 189520] [Curl] Limit capturing extra metrics for Web Inspector when not required. : [Attachment 349959] PATCH
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 17 16:09:40 PDT 2018
Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 189520: [Curl] Limit capturing extra metrics for Web Inspector when not
required.
https://bugs.webkit.org/show_bug.cgi?id=189520
Attachment 349959: PATCH
https://bugs.webkit.org/attachment.cgi?id=349959&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 349959
--> https://bugs.webkit.org/attachment.cgi?id=349959
PATCH
View in context: https://bugs.webkit.org/attachment.cgi?id=349959&action=review
> Source/WebCore/platform/network/curl/CurlRequest.h:112
> + CurlRequest(const ResourceRequest&, CurlRequestClient*, bool
shouldSuspend, bool enableMultipart, bool captureExtendedMetrics,
MessageQueue<Function<void()>>*);
It would be more readable to just pass the enums here, too.
More information about the webkit-reviews
mailing list