[webkit-reviews] review granted: [Bug 189682] DFGValidate should only validate that edges have a result in SSA if we haven't proven that we have OSR exited : [Attachment 349947] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 189682: DFGValidate should only validate that edges have a result in SSA if
we haven't proven that we have OSR exited
https://bugs.webkit.org/show_bug.cgi?id=189682

Attachment 349947: patch

https://bugs.webkit.org/attachment.cgi?id=349947&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 349947
  --> https://bugs.webkit.org/attachment.cgi?id=349947
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349947&action=review

LGTM.

> Source/JavaScriptCore/ChangeLog:11
> +	   This is because the arguments elimination phase doesn't stops doing

/stops/stop/.

> Source/JavaScriptCore/ChangeLog:15
> +	   This patch makes it so that validation is does not fail on code like

/is does/does/.