[webkit-reviews] review denied: [Bug 187545] REGRESSION(r196265): WKWebView fires mouseover, mouseenter, and mouseleave events even when it's in a background window : [Attachment 349936] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 187545: REGRESSION(r196265): WKWebView fires mouseover, mouseenter, and
mouseleave events even when it's in a background window
https://bugs.webkit.org/show_bug.cgi?id=187545

Attachment 349936: Patch

https://bugs.webkit.org/attachment.cgi?id=349936&action=review




--- Comment #69 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349936
  --> https://bugs.webkit.org/attachment.cgi?id=349936
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349936&action=review

> Source/WebCore/page/EventHandler.cpp:1967
> -	       updateMouseEventTargetNode(mouseEvent.targetNode(),
platformMouseEvent, true);
> +	       shouldSendMouseEventsToInactiveWindows(mouseEvent,
platformMouseEvent);

This should be:

if (shouldSendMouseEventsToInactiveWindows())
    updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent,
true);

with:

void shouldSendMouseEventsToInactiveWindows() const;