[webkit-reviews] review granted: [Bug 176281] track.onmute isn't called for a remote MediaStreamTrack when its counter part track is removed from the peer connection : [Attachment 349915] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 176281: track.onmute isn't called for a remote MediaStreamTrack when its
counter part track is removed from the peer connection
https://bugs.webkit.org/show_bug.cgi?id=176281

Attachment 349915: Patch

https://bugs.webkit.org/attachment.cgi?id=349915&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 349915
  --> https://bugs.webkit.org/attachment.cgi?id=349915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349915&action=review

>
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
:489
> +	   auto* backend =
static_cast<LibWebRTCRtpSenderBackend*>(transceiver->sender().backend());

Nit: downcast<LibWebRTCRtpSenderBackend> would be better, although it is
probably a big enough change that you may want to do it in a separate patch.