[webkit-reviews] review denied: [Bug 189520] [Curl] Limit capturing extra metrics for Web Inspector when not required. : [Attachment 349903] PATCH

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 189520: [Curl] Limit capturing extra metrics for Web Inspector when not
required.
https://bugs.webkit.org/show_bug.cgi?id=189520

Attachment 349903: PATCH

https://bugs.webkit.org/attachment.cgi?id=349903&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 349903
  --> https://bugs.webkit.org/attachment.cgi?id=349903
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=349903&action=review

> Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:140
> +    auto curlRequest = CurlRequest::create(request, *this,
CurlRequest::ShouldSuspend::Yes);
> +   
curlRequest->setCaptureExtraNetworkLoadMetricsEnabled(shouldCaptureExtraNetwork
LoadMetrics());

This should be a constructor parameter.  If it's annoying use a default value.