[webkit-reviews] review denied: [Bug 189647] [GStreamer] Add support for AV1 decoding : [Attachment 349882] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 17 03:31:49 PDT 2018
Xabier RodrÃguez Calvar <calvaris at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 189647: [GStreamer] Add support for AV1 decoding
https://bugs.webkit.org/show_bug.cgi?id=189647
Attachment 349882: Patch
https://bugs.webkit.org/attachment.cgi?id=349882&action=review
--- Comment #16 from Xabier RodrÃguez Calvar <calvaris at igalia.com> ---
Comment on attachment 349882
--> https://bugs.webkit.org/attachment.cgi?id=349882
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=349882&action=review
>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2364
> + return av1DecoderFound ? MediaPlayer::IsSupported :
MediaPlayer::IsNotSupported;
> + if (codec.startsWith("av1"_s))
> + return MediaPlayer::IsNotSupported;
> + }
> + return result;
If we are still calling extendedSupportsType then we should not return here and
let the other function filter as well O:)
More information about the webkit-reviews
mailing list