[webkit-reviews] review granted: [Bug 189636] Expose XPCServiceMain on a WebProcess object rather than WKProcessPool : [Attachment 349864] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Alex Christensen <achristensen at apple.com>'s request
for review:
Bug 189636: Expose XPCServiceMain on a WebProcess object rather than
WKProcessPool
https://bugs.webkit.org/show_bug.cgi?id=189636

Attachment 349864: Patch

https://bugs.webkit.org/attachment.cgi?id=349864&action=review




--- Comment #9 from mitz at webkit.org ---
Comment on attachment 349864
  --> https://bugs.webkit.org/attachment.cgi?id=349864
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349864&action=review

(In reply to Alex Christensen from comment #6)
> I did it in
> ObjC to get closer to a world where we have an ObjC bundle API

We do have Objective-C bundle API (it’s the only bundle API that Safari uses on
iOS), in WebProcess/InjectedBundle/API/{Cocoa,mac}. An equivalent, modern place
to put this function declaration would be WKWebProcessPlugIn.h. But since this
API isn’t meant to be called from bundle code, perhaps a new separate header
under API/Cocoa (that imports WKFoundation.h and uses WK_API_AVAILABLE) would
be even better.

> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.h:81
> +WK_EXPORT int WKWebProcessMain(int argc, const char** argv);

Still no availability.