[webkit-reviews] review granted: [Bug 189643] Re-order Node flags based on semantics : [Attachment 349845] Cleanup

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 189643: Re-order Node flags based on semantics
https://bugs.webkit.org/show_bug.cgi?id=189643

Attachment 349845: Cleanup

https://bugs.webkit.org/attachment.cgi?id=349845&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349845
  --> https://bugs.webkit.org/attachment.cgi?id=349845
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=349845&action=review

> Source/WebCore/dom/Node.h:566
> -	   IsConnectedFlag = 1 << 6,
> -	   IsInShadowTreeFlag = 1 << 7,
> -	   IsDocumentNodeFlag = 1 << 8,
> -	   IsShadowRootFlag = 1 << 9,
> +	   IsDocumentNodeFlag = 1 << 6,
> +	   IsShadowRootFlag = 1 << 7,
> +	   IsConnectedFlag = 1 << 8,
> +	   IsInShadowTreeFlag = 1 << 9,
>	   HasRareDataFlag = 1 << 10,

I would prefer all the "= 1 << N" be aligned, so it's easy to see that they are
increasing by one, but not everyone agrees.

> Source/WebCore/dom/Node.h:584
> +	   StyleValidityShift = 22,

Does this break our ability to use this enum with OptionSet<>?