[webkit-reviews] review granted: [Bug 189308] Web Inspector: REGRESSION: breakpoint context menu appears twice in DOM tree : [Attachment 349741] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 189308: Web Inspector: REGRESSION: breakpoint context menu appears twice in
DOM tree
https://bugs.webkit.org/show_bug.cgi?id=189308

Attachment 349741: Patch

https://bugs.webkit.org/attachment.cgi?id=349741&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 349741
  --> https://bugs.webkit.org/attachment.cgi?id=349741
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349741&action=review

r=me

>
Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js:
52
> +	   if
(contextMenu[WI.DOMBreakpointTreeController._contextMenuItemsAddedSymbol])
> +	       return;
> +
> +	  
contextMenu[WI.DOMBreakpointTreeController._contextMenuItemsAddedSymbol] =
true;

I still prefer the double underscore approach. It's just cheaper (a symbol
doesn't need to exist at all times) and simpler in my opinion (no need to jump
around code and its easy to read).