[webkit-reviews] review denied: [Bug 189560] Add stability to tests for web API statistics : [Attachment 349781] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Woodrow Wang
<wwang153 at stanford.edu>'s request for review:
Bug 189560: Add stability to tests for web API statistics
https://bugs.webkit.org/show_bug.cgi?id=189560

Attachment 349781: Patch

https://bugs.webkit.org/attachment.cgi?id=349781&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 349781
  --> https://bugs.webkit.org/attachment.cgi?id=349781
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349781&action=review

> LayoutTests/ChangeLog:8
> +

Please explain *In the changelog* why this helps with stability.

>
LayoutTests/http/tests/webAPIStatistics/canvas-read-and-write-data-collection.h
tml:12
> +    testRunner.dumpAsText();

I think these testRunner calls should be with the one to
testRunner.waitUntilDone(); at the end of the test.
Sorry, I know I recommended this locally but I did not see at the time that
there was already a section taking care of testRunner calls.

Same comment in other tests.

> LayoutTests/http/tests/webAPIStatistics/font-load-data-collection.html:39
> +	   }, 100);

Why 100? Either 0 works consistently or this will introduce flakiness.