[webkit-reviews] review granted: [Bug 189610] WebGL 2 conformance: rgb-format-support.html : [Attachment 349727] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 189610: WebGL 2 conformance: rgb-format-support.html
https://bugs.webkit.org/show_bug.cgi?id=189610

Attachment 349727: Patch

https://bugs.webkit.org/attachment.cgi?id=349727&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 349727
  --> https://bugs.webkit.org/attachment.cgi?id=349727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349727&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:380
> +    // On macOS (OpenGL 4.1) we must emulate GL ES 3/OpenGL 4.2
glGetInternalformativ.

This path might not be just macOS, so just say "On desktop OpenGL"

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:396
> +    // FIXME: The way I understand this is that this will return a MINIMUM
numSamples for all accepeted internalformats.
> +    // However, the true value of this on supported GL versions is gleaned
via a getInternalformativ call that depends on internalformat.

This isn't really a FIXME.