[webkit-reviews] review granted: [Bug 188772] Allow override of viewport configuration : [Attachment 349638] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted James Savage
<james.savage at apple.com>'s request for review:
Bug 188772: Allow override of viewport configuration
https://bugs.webkit.org/show_bug.cgi?id=188772

Attachment 349638: Patch

https://bugs.webkit.org/attachment.cgi?id=349638&action=review




--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349638
  --> https://bugs.webkit.org/attachment.cgi?id=349638
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349638&action=review

> LayoutTests/ChangeLog:15
> +	   * fast/viewport/ios/ipad/baseline.html: Added.

baseline.html is a confusing name. Maybe just no-viewport.html.

> LayoutTests/ChangeLog:17
> +	   * fast/viewport/ios/ipad/meta-viewport-disabled.html: Added.

I would not use  -disabled in a test name; it's too easily confused with the
test being disabled. Call it meta-viewport-ignored.html.

> LayoutTests/fast/viewport/ios/ipad/baseline.html:5
> +    <meta name="viewport" content="">

Is this equivalent to no viewport tag at all?