[webkit-reviews] review granted: [Bug 181341] Web Inspector: Record actions performed on ImageBitmapRenderingContext : [Attachment 348300] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 16:54:18 PDT 2018


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 181341: Web Inspector: Record actions performed on
ImageBitmapRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=181341

Attachment 348300: Patch

https://bugs.webkit.org/attachment.cgi?id=348300&action=review




--- Comment #22 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 348300
  --> https://bugs.webkit.org/attachment.cgi?id=348300
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348300&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:448
> -	   let snapshotIndex = Math.floor(this._index /
WI.RecordingContentView.SnapshotInterval);
> -	   if (!isNaN(this._index) && this._snapshots[snapshotIndex])
> -	      
this._snapshots[snapshotIndex].element.classList.toggle("show-grid",
activated);
> +	   if (!isNaN(this._index))
> +	      
this._previewContainer.firstElementChild.classList.toggle("show-grid",
activated);

Why this change?


More information about the webkit-reviews mailing list