[webkit-reviews] review denied: [Bug 189588] [WPE][GTK] Docs for WebKitWebView::load-failed do not tell which kind of errors are reported : [Attachment 349676] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 189588: [WPE][GTK] Docs for WebKitWebView::load-failed do not tell which
kind of errors are reported
https://bugs.webkit.org/show_bug.cgi?id=189588

Attachment 349676: Patch

https://bugs.webkit.org/attachment.cgi?id=349676&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 349676
  --> https://bugs.webkit.org/attachment.cgi?id=349676
Patch

I'm pretty sure this is not exhaustive:

 * https://gitlab.gnome.org/GNOME/epiphany/issues/533 is caused by G_IO_ERROR,
so we know that, at least, is also possible
 * Epiphany also checks for WEBKIT_POLICY_ERROR, so presumably that is possible
too

I'm quite nervous about documenting anything here unless we are really certain
about the possible error domains. E.g. Epiphany doesn't expect SOUP_HTTP_ERROR
or G_IO_ERROR. So we need to be more confident about what can really happen
here.