[webkit-reviews] review granted: [Bug 189589] Add Copy WebKit Permalink plugin for Sublime Text : [Attachment 349679] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 189589: Add Copy WebKit Permalink plugin for Sublime Text
https://bugs.webkit.org/show_bug.cgi?id=189589

Attachment 349679: Patch

https://bugs.webkit.org/attachment.cgi?id=349679&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 349679
  --> https://bugs.webkit.org/attachment.cgi?id=349679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349679&action=review

Neat! rs=me

> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu:2
> +    { "command": "copy_web_kit_permalink" },

Why "web_kit" and not "webkit"?

> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Default
(OSX).sublime-keymap:2
> +	{ "keys": ["super+ctrl+shift+c"], "command": "copy_web_kit_permalink"
},

Ditto.