[webkit-reviews] review requested: [Bug 189589] Add Copy WebKit Permalink plugin for Sublime Text : [Attachment 349679] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 10:39:13 PDT 2018


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 189589: Add Copy WebKit Permalink plugin for Sublime Text
https://bugs.webkit.org/show_bug.cgi?id=189589

Attachment 349679: Patch

https://bugs.webkit.org/attachment.cgi?id=349679&action=review




--- Comment #1 from Daniel Bates <dbates at webkit.org> ---
Created attachment 349679

  --> https://bugs.webkit.org/attachment.cgi?id=349679&action=review

Patch

I tested this plugin in Sublime Text 3 on Mac version 3.1.1 (build 3176). If
someone wants to test aon Window or Linxu that would be great. It should work
in Sublime Text 2 given that I used
<https://code.tutsplus.com/tutorials/how-to-create-a-sublime-text-2-plugin--net
-22685> as a reference when writing the plugin. For now, there are only key
bindings for Mac because that is the platform I use and is the platform I am
most familiar with the keyboard shortcut conventions for. Do any Windows or
Linux developers have suggestions for good (read: do not conflict with other
apps) key bindings sequences? We need two sequences: one for generating a
permalink without blame annotations and one for generating a permalink with
blame annotations.


More information about the webkit-reviews mailing list