[webkit-reviews] review denied: [Bug 189569] Web Inspector: Opening inspector with a selected element might immediately scroll that element off screen in the DOM Tree outline : [Attachment 349597] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 189569: Web Inspector: Opening inspector with a selected element might
immediately scroll that element off screen in the DOM Tree outline
https://bugs.webkit.org/show_bug.cgi?id=189569

Attachment 349597: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=349597&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 349597
  --> https://bugs.webkit.org/attachment.cgi?id=349597
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=349597&action=review

>> Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js:44
>> +	   
WI.detailsSidebar.addEventListener(WI.Sidebar.Event.CollapsedStateDidChange,
this._elementsTabDetailsSidebarCollapsedStateDidChange, this);
> 
> I think we might also want to re-scroll the node if the sidebar's width
changes too, not just if it collapses.	You should be able to modify
`WI.DOMTreeContentView.prototype.layout`:
> 
>	  if (this.layoutReason === WI.View.LayoutReason.Resize)
>	     
this._domTreeOutline.selectDOMNode(this._domTreeOutline.selectedDOMNode());

Great idea!