[webkit-reviews] review granted: [Bug 189584] [GStreamer] WebAudio idle/silence playback improvements : [Attachment 349662] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 189584: [GStreamer] WebAudio idle/silence playback improvements
https://bugs.webkit.org/show_bug.cgi?id=189584

Attachment 349662: Patch

https://bugs.webkit.org/attachment.cgi?id=349662&action=review




--- Comment #4 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 349662
  --> https://bugs.webkit.org/attachment.cgi?id=349662
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349662&action=review

It would be interesting to be a bit more verbose in the ChangLog

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:385
> +

Remove extra line...

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:396
> +	       g_usleep(1000);

I think we can use WTF::sleep, can't we?