[webkit-reviews] review requested: [Bug 189585] [GLib] Fix format string in KeyedEncoderGlib::beginObject(). : [Attachment 349664] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has asked  for review:
Bug 189585: [GLib] Fix format string in KeyedEncoderGlib::beginObject().
https://bugs.webkit.org/show_bug.cgi?id=189585

Attachment 349664: Patch

https://bugs.webkit.org/attachment.cgi?id=349664&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 349664
  --> https://bugs.webkit.org/attachment.cgi?id=349664
Patch

I had to stare at this for a while to convince myself it should be different
from KeyedEncoderGlib::beginArray, but I think the change is correct.

But surely this changes the database serialization format. How do we fix
existing databases that are already broken? Will the critical continue to occur
forever for existing broken databases? That requires further investigation.
Hopefully we have some mechanism somewhere to handle incompatible changes like
this? I'd like Carlos to review this, please.