[webkit-reviews] review granted: [Bug 189545] [GTK] Make script dialogs modal to the current web view only : [Attachment 349543] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 189545: [GTK] Make script dialogs modal to the current web view only
https://bugs.webkit.org/show_bug.cgi?id=189545

Attachment 349543: Patch

https://bugs.webkit.org/attachment.cgi?id=349543&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 349543
  --> https://bugs.webkit.org/attachment.cgi?id=349543
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349543&action=review

Could you show before/after screenshots for both dialogs?

And does this make the text selectable?

> Source/WebCore/platform/gtk/po/POTFILES.in:32
> -../../../WebKit/UIProcess/API/gtk/WebKitScriptDialogGtk.cpp
> +../../../WebKit/UIProcess/API/gtk/WebKitScriptDialogImpl.cpp

Wow, you remembered... you're a translation hero, now.