[webkit-reviews] review denied: [Bug 189568] WebPageProxy::reportPageLoadResult can crash on some code paths : [Attachment 349599] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied Keith Rollin
<krollin at apple.com>'s request for review:
Bug 189568: WebPageProxy::reportPageLoadResult can crash on some code paths
https://bugs.webkit.org/show_bug.cgi?id=189568

Attachment 349599: Patch

https://bugs.webkit.org/attachment.cgi?id=349599&action=review




--- Comment #4 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 349599
  --> https://bugs.webkit.org/attachment.cgi?id=349599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349599&action=review

r- to fix patch applying to trunk and consider feedback.

> Source/WebKit/UIProcess/WebPageProxy.cpp:3564
> +	   if (m_pageLoadStart)

Why not just add an early return to reportPageLoadResult() so that the engineer
that adds new calls to it doesn’t have to remember this prerequisite?

Then you can remove all the checks (or add Debug asserts if you want to
document the expected state of m_pageLoadStart).