[webkit-reviews] review granted: [Bug 189504] [Cocoa] Complete support for Paste as Quotation : [Attachment 349574] Add PasteAsQuotation command and -[WKWebView _pasteAsQuotation:]

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted mitz at webkit.org's request for
review:
Bug 189504: [Cocoa] Complete support for Paste as Quotation
https://bugs.webkit.org/show_bug.cgi?id=189504

Attachment 349574: Add PasteAsQuotation command and -[WKWebView
_pasteAsQuotation:]

https://bugs.webkit.org/attachment.cgi?id=349574&action=review




--- Comment #13 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 349574
  --> https://bugs.webkit.org/attachment.cgi?id=349574
Add PasteAsQuotation command and -[WKWebView _pasteAsQuotation:]

View in context: https://bugs.webkit.org/attachment.cgi?id=349574&action=review

r=mews

> Source/WebCore/editing/Editor.h:135
> +	   AsQuotation = 2 << 0,

‽‽‽‽

> LayoutTests/editing/pasteboard/4930986-1-paste-as-quotation.html:17
> +document.addEventListener("beforecopy", (event) => { event.preventDefault();
});

Nit - no need for the { } around the function body.

> LayoutTests/editing/pasteboard/4930986-2-paste-as-quotation.html:13
> +    document.addEventListener("beforecopy", (event) => {
event.preventDefault(); });

(Ditto)

> LayoutTests/editing/pasteboard/4930986-3-paste-as-quotation.html:17
> +document.addEventListener("beforecopy", (event) => { event.preventDefault();
});

(Ditto)