[webkit-reviews] review requested: [Bug 189552] builtins directory causes name conflict on Python 3 : [Attachment 349579] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 12 14:15:52 PDT 2018


Mike Gorse <mgorse at suse.com> has asked	for review:
Bug 189552: builtins directory causes name conflict on Python 3
https://bugs.webkit.org/show_bug.cgi?id=189552

Attachment 349579: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=349579&action=review




--- Comment #1 from Mike Gorse <mgorse at suse.com> ---
Created attachment 349579

  --> https://bugs.webkit.org/attachment.cgi?id=349579&action=review

Proposed patch.

Renames Source/JavaScriptCore/Scripts/builtins to wkbuiltins, to avoid name
conflict when building with Python 3.
Will see if this builds on macOS/iOS; don't have a setup to try.


More information about the webkit-reviews mailing list