[webkit-reviews] review granted: [Bug 189519] Make IPC::SharedBufferDataReference a type that decodes into but does not inherit from IPC::DataReference : [Attachment 349560] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 189519: Make IPC::SharedBufferDataReference a type that decodes into but
does not inherit from IPC::DataReference
https://bugs.webkit.org/show_bug.cgi?id=189519

Attachment 349560: Patch

https://bugs.webkit.org/attachment.cgi?id=349560&action=review




--- Comment #31 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 349560
  --> https://bugs.webkit.org/attachment.cgi?id=349560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349560&action=review

r=me

> Source/WebKit/Platform/IPC/SharedBufferDataReference.h:39
> +    SharedBufferDataReference(const uint8_t* data, size_t size)

I personally preference would have been to not have this constructor and use 2
separate IPC messages for the specific case that sometimes sends a
SharedBuffer, somethings data+size. It looks confusing to me to construct a
SharedBufferDataReference from anything else than a SharedBuffer but your
call..