[webkit-reviews] review granted: [Bug 189532] Fix color stop blending in conic gradients for stops past 1 : [Attachment 349577] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 12 13:28:04 PDT 2018
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 189532: Fix color stop blending in conic gradients for stops past 1
https://bugs.webkit.org/show_bug.cgi?id=189532
Attachment 349577: Patch
https://bugs.webkit.org/attachment.cgi?id=349577&action=review
--- Comment #16 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349577
--> https://bugs.webkit.org/attachment.cgi?id=349577
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=349577&action=review
Make sure the EWS is green before landing.
> Source/WebCore/ChangeLog:12
> + Test: fast/gradients/conic-repeating-last-stop.html
> +
> + Calculation was wrong, fixed it, and wrote a test that failed
> + without the change, and passes with it.
We normally put the Test: line after the description.
More information about the webkit-reviews
mailing list