[webkit-reviews] review requested: [Bug 188871] Implement safe browsing in WebKit : [Attachment 349462] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has asked  for review:
Bug 188871: Implement safe browsing in WebKit
https://bugs.webkit.org/show_bug.cgi?id=188871

Attachment 349462: Patch

https://bugs.webkit.org/attachment.cgi?id=349462&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 349462
  --> https://bugs.webkit.org/attachment.cgi?id=349462
Patch

This patch does address the concerns from earlier in this bug.
With the new delegate callback in WKUIDelegate, an app will have the ability to
see and control whether a safe browsing warning is being shown.
Because loading an unsafe URL in an iframe is determined to indicate that the
whole page should not be shown, we cannot use WKNavigationDelegate's existing
error callbacks because they are not called for iframe navigation.
Because we want unmodified clients to get this safety coverage but still have
the ability to not be broken, this is the design.  Re-requesting review.